-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add support to publish message to specific clients #797
base: main
Are you sure you want to change the base?
Conversation
@@ -187,7 +187,7 @@ public RouteResult ifFailed(Runnable action) { | |||
|
|||
private static final Logger LOG = LoggerFactory.getLogger(PostOffice.class); | |||
|
|||
private static final Set<String> NO_FILTER = new HashSet<>(); | |||
private static final Set<String> NO_FILTER = Collections.unmodifiableSet(new HashSet<>()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't change the semantics of NO_FILTER this time, but I think NO_FILTER should be unmodifiable.
Hi @maxwang789 thanks for your interest in the project. |
HI @andsel You are correct, this is not part of MQTT specification. |
Hi @maxwang789 I understand your reason, but |
Release notes
What does this PR do?
add support to publish message to specific clients
It's a fixed version of #786
Why is it important/What is the impact to the user?
The original request is that one request will be sent to topic "/request", but the response should be sent back on another topic "/response".
With these modifications, the embedding broker could distinguish all connections and support such send/resp mechanism without MQTT5 version.
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases